Ivan Gretsky

Partials' overrides didn't work because of a typo. I think this PR fixes that.

Big thanks for this, @teppo! This was supposed to be a New Year present judging by the date. I was away and could not receive it. Luckily we have an Old New Year here in Russia, so the present is still very much on time)))) I have quickly checked this new feature. Seems exactly what I was describing as the first option. It works great for template views. It didn't for Component views, but it seems I could fix it with this PR. I am not sure partials work ok yet. Will check later. What else should I check? I would love to have an option to configure Wireframe to not use default view files are used in case a prefixed version doesn't exist. This way it would be easier to find out what else should be overridden when creating themes. I guess the best thing would be to have 3 options here: Use default view files are used in case a prefixed version doesn't exist. Through an error in case a prefixed version doesn't exist. Output nothing in case a prefixed version doesn't exist. It would be great to have the second option from my OP one day, but this solves my current demands 100%. Really cool! Again, big thanks for this! I love the way you improve Wireframe taking our input into account. And it really amazing how we all can create the software together these days) We often take this for granted, but it is really a miracle looking at it from back in the days))

@teppo, just in case you are in doubt what is that what you can gift to the world this New Year, I am quite sure the world will be delighted with the new Wireframe version with themes support)) Well, maybe not the whole world, but certainly some minor parts of it))) I do not know how do to say "happy upcoming New Year" in English or Suomi, so I'll put it here in Russian: "С наступающим!"

The only one that comes to my mind is User Activity of ProDevTools suite. This is of course a Pro module, but it is the only one of the kind that I have worked with. I hope I understood right what you have been asking about)

I have done this. Hope it will get some more deserved attention to PW. And this post is supposed to bring this pinned topic up in the recently updated list for those who, like myself, read the news there. And to get some more ⭐⭐⭐⭐⭐ for us on github)

Good day, @kongondo! Have you managed to get it to work? P.S. I have managed to make it work both for web and cli. The only thing that I still cannot figure out is how to launch a specific php file (see an example without ddev below). Still can't find out how to start it not with php but with ddev exec php. { "name": "Launch test.php", "type": "php", "request": "launch", "program": "${workspaceFolder}/test.php", "cwd": "${workspaceFolder}", "port": 0, "runtimeArgs": [ "-dxdebug.start_with_request=yes" ], "env": { "XDEBUG_MODE": "debug,develop", "XDEBUG_CONFIG": "client_port=${port}" } } I have tries adding "runtimeExecutable": "ddev exec php", but it didn't work for some reason: Error: spawn ddev exec php ENOENT at ChildProcess._handle.onexit (node:internal/child_process:285:19) at onErrorNT (node:internal/child_process:483:16) at process.processTicksAndRejections (node:internal/process/task_queues:82:21) { errno: -2, code: 'ENOENT', syscall: 'spawn ddev exec php', path: 'ddev exec php', spawnargs: [ '-dxdebug.start_with_request=yes', '...', '...' ] }

Thanks for an interesting perspective and for the commendation @Alexander! As you already mentioned your new open source thing, expand on it for everybody. We are in the Pub anyway))

Ok. Now I got it better, I think. Now I have _init.php prepending wireframe.php that generates settings array, that I then pass to wireframe->render(). Some absolutely general settings I pass down with setting() function. If we had composers, we could move all my code in _init.php and wireframe.php to a dedicated class. Where would these composers be in places if file structure? How would we access data from them in views?

(Deleted)

Great! Looking forward to see it in Wireframe! Thanks for your work and talent!

Yes. But I think there could be an option to either use parent's features or to indicate that this one is yet to be implemented in a theme (through an error or warning).

I mean pull request in the module repo - https://github.com/kongondo/MenuBuilder/pulls Thanks for the code! I've seen it. But didn't try yet. A github pull request is just an easier way to deal with code change proposals.

Great! Did you create a PR, so we can like it and make it easier for @kongondo to fix this for all of us?

Good day @teppo! Another question from me) I am building a solution based on PW and Wireframe, that needs the theming functionality. That is switching theme (default views) for all the views and components. Layouts and partials probably too. Is there an easy way to achieve this with current code? Maybe a couple of hooks? I can see two ways how it could work. Put `alternative-default.php` everywhere the `default.php` files are and somehow tell Wireframe to use those prefixed files. If there is another view except the default one, the prefix should work as well. Like `alternative-json.php`. Probably an option should be available whether to fallback to defaults without the prefix or not. Create an overrides or theme folder somewhere and have somehow point Wireframe to use views from there. For my personal need the 1st approach seems to be a better one. But just maybe it is easy enough to provide possibility for both? Thanks!

Thanks for sharing. I am still wrapping my head around the concept. I it passing variables to a specific view... seems like it. But I am not sure I quite understand what problem does it solve. If you would like to discuss it, a real-world example would help)